Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 Breaking Changes #214

Closed
5 tasks done
ZacSweers opened this issue Jun 26, 2018 · 10 comments
Closed
5 tasks done

1.0 Breaking Changes #214

ZacSweers opened this issue Jun 26, 2018 · 10 comments

Comments

@ZacSweers
Copy link
Collaborator

ZacSweers commented Jun 26, 2018

After RxJava 2.2 is released, we'll be good to release AutoDispose 1.0. There are some breaking changes we've held off on making that we plan to make in 1.0.

  • Rename kotlin extension artifacts to -ktx to match convention
  • Remove all the old Scoper APIs
  • Switch to androidx/jetpack artifacts (should line up around the same time)
  • Remove deprecated kotlin extension functions
  • Add module docs for kotlin projects
@jobinlawrance
Copy link

Will this include support for RxKotlin extension functions like subscribeBy() ?

@ZacSweers
Copy link
Collaborator Author

Nope! For reasons discussed in #127, we have no plans to add a subscribeBy() API to the public artifact.

@ShaishavGandhi
Copy link
Collaborator

Are the checklist items open for contribution? Wouldn't mind take a crack at one of them.

@ZacSweers
Copy link
Collaborator Author

ZacSweers commented Jul 18, 2018

Yes, but not till we have a more concrete time frame for 1.0. I think we'll try doing another release between now and then

@ShaishavGandhi
Copy link
Collaborator

Sounds good!

@ShaishavGandhi
Copy link
Collaborator

Switching to androix might be safe now. Google released RC1 a week ago and the public API is finalized.

@ZacSweers
Copy link
Collaborator Author

We might do an RC with the switched APIs, but not yet

@ZacSweers
Copy link
Collaborator Author

ZacSweers commented Sep 24, 2018

jetpack libs 1.0 are out. I'm on vacation this week and at kotlinconf the next, but rough plan is to do the following simultaneous releases:

1.0.0-RC3: support 28 final, latest arch versions
1.0.0: androidx 1.0/arch 2.0

Kotlin 1.3 final as well depending on timing

@ShaishavGandhi
Copy link
Collaborator

Haha I was just about to make a PR with the androidx changes! This plan sounds safer though. If you haven't already done the changes, I'd be happy to send the PR for after the RC3 release.

@ZacSweers
Copy link
Collaborator Author

This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants