Add untilEvent overload for AndroidLifecycleScopeProvider#from #107
Conversation
|
|
Could you call those out, perhaps in comments? |
| /** | ||
| * Creates a {@link AndroidLifecycleScopeProvider} for Android LifecycleOwners. | ||
| * | ||
| * @param owner the owner to scope for | ||
| * @param owner the owner to scope for. |
There was a problem hiding this comment.
Very minor: Missing dot.
| * Creates a {@link AndroidLifecycleScopeProvider} for Android Lifecycles. | ||
| * | ||
| * @param lifecycle the lifecycle to scope for | ||
| * @param lifecycle the lifecycle to scope for. |
| @@ -35,7 +37,7 @@ | |||
|
|
|||
| private static final String TAG = "AutoDispose"; | |||
|
|
|||
| @Override protected void onCreate(Bundle savedInstanceState) { | |||
| @Override protected void onCreate(@Nullable Bundle savedInstanceState) { | |||
There was a problem hiding this comment.
Added @Nullable annotation as suggested by Android Studio.
| @@ -97,6 +99,21 @@ | |||
| .to(AutoDispose.with(AndroidLifecycleScopeProvider.from(this)).<Long>forObservable()) | |||
| .subscribe(new Consumer<Long>() { | |||
| @Override public void accept(Long num) throws Exception { | |||
| Log.i(TAG, "Started in onResume(), running until in onPause(): " + num); | |||
There was a problem hiding this comment.
Fixed "...running until in onDestroy" to "...running until in onPause".
|
I have added comments and signed the cla! |
| } | ||
|
|
||
| @Override public Lifecycle.Event peekLifecycle() { | ||
| return lifecycleObservable.getValue(); | ||
| } | ||
|
|
||
| private static class UntilEventFunction implements Function<Lifecycle.Event, Lifecycle.Event> { |
There was a problem hiding this comment.
Good idea. I'd initially thought about doing it as a filter, but with this you hook in nicely to the api
There was a problem hiding this comment.
Yeah I started trying that but could not get it to work, so came up with this approach instead.
| * @param untilEvent the event until the scope is valid. | ||
| * @return a {@link AndroidLifecycleScopeProvider} against this owner. | ||
| */ | ||
| public static AndroidLifecycleScopeProvider from(LifecycleOwner owner, |
There was a problem hiding this comment.
nit: put both of these on the next line or at least make until event use a normal trailing indent
| @@ -73,8 +73,8 @@ public static AndroidLifecycleScopeProvider from(LifecycleOwner owner) { | |||
| * @param untilEvent the event until the scope is valid. | |||
| * @return a {@link AndroidLifecycleScopeProvider} against this owner. | |||
| */ | |||
| public static AndroidLifecycleScopeProvider from(LifecycleOwner owner, | |||
| Lifecycle.Event untilEvent) { | |||
| public static AndroidLifecycleScopeProvider from( | |||
There was a problem hiding this comment.
One more nit - if they start on a new line, let's make each of them a separate line
There was a problem hiding this comment.
Like this?
public static AndroidLifecycleScopeProvider from(
LifecycleOwner owner,
Lifecycle.Event untilEvent) {
|
Thanks! I'll cut a patch release soon-ish |
|
@hzsweers Hope it comes quickly |
Description: This adds two overloads to the
AndroidLifecycleScopeProvider#frommethods, to achieve the same functionality asRxLifecycle'sbindUntilEvent.I have taken the approach of returning the set value in the
correspondingEventsfunction. It works, but I'm not sure if that is the right way.I also fixed minor issues I found while scanning through the code. I can revert those if not appropriate.
Related issue(s): #72, #104