Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindUntilEvent with architecture components #104

Closed
rubengees opened this issue Oct 8, 2017 · 2 comments
Closed

bindUntilEvent with architecture components #104

rubengees opened this issue Oct 8, 2017 · 2 comments

Comments

@rubengees
Copy link
Contributor

Version: 0.3.0

I was previously using RxLifecycle and played around a bit with AutoDispose. So far it works great, but i miss the bindUntilEvent method from RxLifecycle.
I have seen the other issue about this, but could not manage to get it to work, especially when using architecture components integration...
Some samples or even better, a first class api would be very appreciated.

My current RxLifecycle code looks like this:

errorButton.clicks()
    .bindUntilEvent(this, Lifecycle.Event.ON_DESTROY)
    .subscribe {
        // Do something.
     }

Thanks in advance!

@ZacSweers
Copy link
Collaborator

Hmmm, I suppose we could have an overload for from that accepts a target event and just filters on that. Interested in contributing a PR? If not I can get around to it this week

@ZacSweers
Copy link
Collaborator

Done in #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants