Fix ViewAttachEventsObservable not observing observer contract

uber · Nov 18, 2017 · 07f0f1e · 07f0f1e
1 parent cb432a8
commit 07f0f1e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...ispose-android/src/main/java/com/uber/autodispose/android/ViewAttachEventsObservable.java b/...ispose-android/src/main/java/com/uber/autodispose/android/ViewAttachEventsObservable.java
@@ -37,6 +37,8 @@ final class ViewAttachEventsObservable extends Observable<ViewLifecycleEvent> {
   }
 
   @Override protected void subscribeActual(Observer<? super ViewLifecycleEvent> observer) {
+    Listener listener = new Listener(view, observer);
+    observer.onSubscribe(listener);
     if (!isMainThread()) {
       observer.onError(new IllegalStateException("Views can only be bound to on the main thread!"));
       return;
@@ -46,8 +48,6 @@ final class ViewAttachEventsObservable extends Observable<ViewLifecycleEvent> {
       // Emit the last event, like a behavior subject
       observer.onNext(ViewLifecycleEvent.ATTACH);
     }
-    Listener listener = new Listener(view, observer);
-    observer.onSubscribe(listener);
     view.addOnAttachStateChangeListener(listener);
   }