Moved default shutdownReporter impl to AbstractReporterBenchmark

uber-java · Aug 13, 2021 · 8fd2ba2 · 8fd2ba2
1 parent 1b616f4
commit 8fd2ba2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/core/src/jmh/java/com/uber/m3/tally/AbstractReporterBenchmark.java b/core/src/jmh/java/com/uber/m3/tally/AbstractReporterBenchmark.java
@@ -151,7 +151,10 @@ public void teardown() {
     }
 
     public abstract Reporter bootReporter();
-    public abstract void shutdownReporter(Reporter reporter);
+
+    public void shutdownReporter(Reporter reporter) {
+        reporter.close();
+    }
 
     @State(Scope.Thread)
     public static class Counter {

diff --git a/...s/src/jmh/java/com/uber/m3/tally/experimental/prometheus/PrometheusReporterBenchmark.java b/...s/src/jmh/java/com/uber/m3/tally/experimental/prometheus/PrometheusReporterBenchmark.java
@@ -32,8 +32,4 @@ public PrometheusReporter bootReporter() {
                 .build();
     }
 
-    @Override
-    public void shutdownReporter(PrometheusReporter reporter) {
-        reporter.close();
-    }
 }
diff --git a/statsd/src/jmh/java/com/uber/m3/tally/statsd/StatsdReporterBenchmark.java b/statsd/src/jmh/java/com/uber/m3/tally/statsd/StatsdReporterBenchmark.java
@@ -25,14 +25,11 @@
 import com.uber.m3.tally.AbstractReporterBenchmark;
 
 public class StatsdReporterBenchmark extends AbstractReporterBenchmark<StatsdReporter> {
+
     @Override
     public StatsdReporter bootReporter() {
         StatsDClient statsd = new NonBlockingStatsDClient("statsd-test", "localhost", 1235);
         return new StatsdReporter(statsd);
     }
 
-    @Override
-    public void shutdownReporter(StatsdReporter reporter) {
-        reporter.close();
-    }
 }