Add option to increase the level of a logger #775
Conversation
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
==========================================
+ Coverage 98.19% 98.21% +0.01%
==========================================
Files 42 43 +1
Lines 2275 2293 +18
==========================================
+ Hits 2234 2252 +18
Misses 33 33
Partials 8 8
Continue to review full report at Codecov.
|
|
I think this is related to #581 , but when I got the author correctly he wishes an option to change the loglevel on a per message basis rather than just having an easy way to create a new child logger which prints at a different log level. I'll leave this note here and reference here, so that issue as it might help some of the users stumbling across #581 |
zapcore/level_filter.go
Outdated
| // NewLevelCore creates a core that can be used to increase the level of an existing | ||
| // Core. It cannot be used to decrease the logging level, as it acts as a filter | ||
| // before calling the underlying core. | ||
| func NewLevelCore(core Core, level LevelEnabler) Core { |
There was a problem hiding this comment.
I suspect this needs a similar name that implies increasing levels only.
We can't protect against it, but we can access the |
|
Logging to errorOutput seems reasonable. I agree that having this error out |
We've had a few requests on how to change the level of a logger. With the current APIs, it's not possible to reduce the log level (e.g., go from Info to Debug), but it is possible to increase the level using `WrapCore` with a custom filtering core. Since it's a common request, I think we should add an option to make this easy to use. I want to make sure "increase" is part of the API to avoid confusion on whether it can reduce the log level. Fixes #774.
prashantv
force-pushed
the
increase_level
branch
from
b7c0c88 to
1653481
Compare
prashantv
changed the title
|
Updated with more explicit name + error if the level is decreased. Could definitely improve the message so looking for suggestions |
Co-Authored-By: Abhinav Gupta <[email protected]>
Co-Authored-By: Abhinav Gupta <[email protected]>
We've had a few requests on how to change the level of a logger. With the current APIs, it's not possible to reduce the log level (e.g., go from Info to Debug), but it is possible to increase the level using `WrapCore` with a custom filtering core. Since it's a common request, I think we should add an option to make this easy to use. I want to make sure "increase" is part of the API to avoid confusion on whether it can reduce the log level. Fixes uber-go#774.
We've had a few requests on how to change the level of a logger. With
the current APIs, it's not possible to reduce the log level (e.g., go
from Info to Debug), but it is possible to increase the level using
WrapCorewith a custom filtering core.Since it's a common request, I think we should add an option to make
this easy to use.
I want to make sure "increase" is part of the API to avoid confusion on
whether it can reduce the log level.
Fixes #774.