Disable HTMLEscape in reflect JSON encoder #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #700. Zap's custom JSON encoder does not escape HTML, so make encoding by the reflect-based JSON encoder work the same way.
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 97.39% 97.39% +<.01%
==========================================
Files 40 40
Lines 2108 2109 +1
==========================================
+ Hits 2053 2054 +1
Misses 47 47
Partials 8 8
Continue to review full report at Codecov.
|
jcorbin
approved these changes
Apr 26, 2019
abhinav
approved these changes
Apr 27, 2019
lixingwang
added a commit
to lixingwang/zap
that referenced
this pull request
May 10, 2019
* master: README: Switch to travis-ci.com for badge (uber-go#709) Fix changelog links for 675 Prep for 1.10.0 release, update CHANGELOG (uber-go#705) Add Go 1.12 for Travis (uber-go#707) Fix call depth of standard logger in go1.12 (uber-go#706) Fix inconsistency between MapObjectEncoder's AddByteString and AppendByteString (uber-go#657) Disable HTMLEscape in reflect JSON encoder (uber-go#704)
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
Fixes uber-go#700. Zap's custom JSON encoder does not escape HTML, so make encoding by the reflect-based JSON encoder work the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700.
Zap's custom JSON encoder does not escape HTML, so make encoding
by the reflect-based JSON encoder work the same way.