Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing import comment #574

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Add missing import comment #574

merged 1 commit into from
Apr 11, 2018

Conversation

akshayjshah
Copy link
Contributor

We let one exposed package sneak through without an import comment.
There's no practical way for anyone to be using with the wrong import
path, but let's clean up anyways.

We let one exposed package sneak through without an import comment.
There's no practical way for anyone to be using with the wrong import
path, but let's clean up anyways.
@codecov
Copy link

codecov bot commented Apr 11, 2018

Codecov Report

Merging #574 into master will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   97.06%   97.45%   +0.39%     
==========================================
  Files          39       39              
  Lines        2279     2001     -278     
==========================================
- Hits         2212     1950     -262     
+ Misses         59       43      -16     
  Partials        8        8
Impacted Files Coverage Δ
buffer/buffer.go 100% <ø> (ø) ⬆️
zapcore/console_encoder.go 96.49% <0%> (-1.07%) ⬇️
zapcore/error.go 93.75% <0%> (-0.7%) ⬇️
stacktrace.go 97.87% <0%> (-0.44%) ⬇️
logger.go 94.49% <0%> (-0.36%) ⬇️
zapcore/memory_encoder.go 98.66% <0%> (-0.02%) ⬇️
writer.go 100% <0%> (ø) ⬆️
level.go 100% <0%> (ø) ⬆️
zapcore/json_encoder.go 100% <0%> (ø) ⬆️
zapcore/tee.go 100% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85c78b...5a1566c. Read the comment docs.

@akshayjshah akshayjshah merged commit 215bfd4 into master Apr 11, 2018
@akshayjshah akshayjshah deleted the ajs-import-comments branch April 11, 2018 23:07
cgxxv pushed a commit to cgxxv/zap that referenced this pull request Mar 25, 2022
We let one exposed package sneak through without an import comment.
There's no practical way for anyone to be using with the wrong import
path, but let's clean up anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants