Make level configurable for RedirectStdLog #508
Conversation
This change introduces a new function `RedirectStdLogAt`. It has the same behaviour as `RedirectStdLog` but allows providing a log level to be used by used `*log.Logger`.
|
|
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 97.19% 97.22% +0.03%
==========================================
Files 37 37
Lines 2243 2272 +29
==========================================
+ Hits 2180 2209 +29
Misses 56 56
Partials 7 7
Continue to review full report at Codecov.
|
| logger := l.WithOptions(AddCallerSkip(_stdLogDefaultDepth + _loggerWriterDepth)) | ||
| var logFunc func(string, ...zapcore.Field) | ||
| switch level { | ||
| case DebugLevel: |
There was a problem hiding this comment.
I can imagine a levelToFunc function here to DRY.
There was a problem hiding this comment.
Agreed! You've been patient enough, though - I'm happy to merge without that and fix it myself :)
|
@akshayjshah What do you think? |
|
@akshayjshah @billf bump. |
|
@akshayjshah @billf Is there anything I can help out with to get this PR through quicker? :-) |
|
No - I'm really sorry for the absurd delay. Family, work, etc. - reviewing now. |
| logger := l.WithOptions(AddCallerSkip(_stdLogDefaultDepth + _loggerWriterDepth)) | ||
| var logFunc func(string, ...zapcore.Field) | ||
| switch level { | ||
| case DebugLevel: |
There was a problem hiding this comment.
Agreed! You've been patient enough, though - I'm happy to merge without that and fix it myself :)
|
@akshayjshah Thanks guys! 🙇 and thanks for the good work on it. |
This change introduces a new function
RedirectStdLogAt. It has the same behaviour asRedirectStdLogbut allows providing a log level to be used by used*log.Logger.