Update benchmarks #1024
Merged
Update benchmarks #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all benchmark and zapgrpc test dependencies to their latest versions. We are not updating go.mod at the root of zap because we are not increasing the minimum version constraint for any of Zap's actual dependencies.
Update benchmark results by running `make updatereadme`.
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 47 47
Lines 2064 2064
=======================================
Hits 2027 2027
Misses 29 29
Partials 8 8 Continue to review full report at Codecov.
|
sywhang
approved these changes
Nov 5, 2021
sywhang
added a commit
to sywhang/zap
that referenced
this pull request
Jul 13, 2022
It's been a while since we last updated the benchmark numbers in README (last update was uber-go#1024). This updates the benchmarks in README by running `make updatereadme`. Internal Ref: GO-1506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates dependencies for all unpublished submodules of Zap
(benchmarks and zapgrpc/test).
Note that we do not update the minimum dependencies for Zap itself.
We don't need newer versions of any dependency than Zap currently uses.
We update the benchmark numbers in the README
by running
make updatereadme.That uses .readme.tmpl to generate the README,
but the template was not updated
when we changed the README in #752, #883, and #940.
So this change also updates the README template.
Supersedes #992
Ref GO-986