Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Prune ex-service peers on membership change #116

Merged
merged 6 commits into from
Nov 10, 2015
Merged

Conversation

jcorbin
Copy link
Contributor

@jcorbin jcorbin commented Nov 3, 2015

  • add peer pruning facility
  • add connectedPeerServices index so that we can correctly handle multi-tenant services
  • implement a long standing TODO in exit -> forward transition under membership change

r @Raynos @rf

@jcorbin jcorbin force-pushed the prune_peers_ex_forward branch from f5fc224 to 9ca027e Compare November 3, 2015 22:57
@@ -51,6 +52,8 @@ var RATE_LIMIT_KILLSWITCH = 'killswitch';

var CN_HEADER_BUFFER = new Buffer('cn');

// TODO: audit all peer.drain for dupe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need TODO this before merging

@jcorbin
Copy link
Contributor Author

jcorbin commented Nov 4, 2015

This lays the groundwork for pruning ex-affinity peers in #66.

@jcorbin jcorbin force-pushed the prune_peers_ex_forward branch from 4abed1f to e5e5cac Compare November 5, 2015 18:46
@jcorbin jcorbin mentioned this pull request Nov 5, 2015
@jcorbin jcorbin force-pushed the prune_peers_ex_forward branch 2 times, most recently from dbdd406 to 07b7099 Compare November 6, 2015 01:08
@jcorbin
Copy link
Contributor Author

jcorbin commented Nov 6, 2015

Now depends on #130

@jcorbin jcorbin force-pushed the prune_peers_ex_forward branch 2 times, most recently from 25d2d2d to b7bb7ed Compare November 6, 2015 01:45
@jcorbin
Copy link
Contributor Author

jcorbin commented Nov 6, 2015

This is now passing tests, and ready for review after #133.

@jcorbin
Copy link
Contributor Author

jcorbin commented Nov 10, 2015

Reviewed in person, merging

jcorbin added a commit that referenced this pull request Nov 10, 2015
Prune ex-service peers on membership change
@jcorbin jcorbin merged commit 5d6185a into master Nov 10, 2015
@jcorbin jcorbin deleted the prune_peers_ex_forward branch November 10, 2015 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants