This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Prune ex-service peers on membership change #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5fc224
to
9ca027e
Compare
@@ -51,6 +52,8 @@ var RATE_LIMIT_KILLSWITCH = 'killswitch'; | |||
|
|||
var CN_HEADER_BUFFER = new Buffer('cn'); | |||
|
|||
// TODO: audit all peer.drain for dupe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need TODO this before merging
This lays the groundwork for pruning ex-affinity peers in #66. |
4abed1f
to
e5e5cac
Compare
Merged
dbdd406
to
07b7099
Compare
Now depends on #130 |
25d2d2d
to
b7bb7ed
Compare
This is now passing tests, and ready for review after #133. |
b7bb7ed
to
453d0bc
Compare
Reviewed in person, merging |
jcorbin
added a commit
that referenced
this pull request
Nov 10, 2015
Prune ex-service peers on membership change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r @Raynos @rf