Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes and improvements #14

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Various fixes and improvements #14

merged 7 commits into from
Apr 5, 2023

Conversation

HeDo88TH
Copy link
Contributor

@HeDo88TH HeDo88TH commented Apr 5, 2023 •
edited
Loading

  • Added windows build instructions (with vcpkg)
  • Updated model link in the readme to the newest
  • Closed dangling file fingerprint
  • Added simple build workflow

Code cleanup:

  • consistent indentation (4 spaces)
  • consistent spacing between braces
  • consistent statement alignment
  • usage of auto and const where advisable
  • replaced exit(CODE) with return CODE
  • use of emplace_back instead of push_back

@github-actions
Copy link

github-actions bot commented Apr 5, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@HeDo88TH
Copy link
Contributor Author

HeDo88TH commented Apr 5, 2023

I have read the CLA Document and I hereby sign the CLA

@HeDo88TH
Copy link
Contributor Author

HeDo88TH commented Apr 5, 2023

recheck

@pierotofy
Copy link
Member

Not a huge fan of the code cleanup changes, but thanks for the fixes and additions. 🙏

@pierotofy pierotofy merged commit c922b44 into uav4geo:main Apr 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeDo88TH @pierotofy