Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heterotrophic respiration increases and doesn't drop back down post-fire #721

Open
amullen01 opened this issue Jun 13, 2024 · 11 comments
Open
Assignees
Labels
bug science Issues affecting scientific interpretation of modeling results

Comments

@amullen01
Copy link
Collaborator

Issue discovered when initiating fire at various years during the transient for two Birch and Black Spruce community types calibrated for caribou-poker creek. Heterotrophic respiration increases post-fire and never returns to pre-fire levels. This tilts the ecosystem to a strong C source for perpetuity, which is likely not in line with reality.

C_Fluxes_fire_exps_post_fix

@amullen01
Copy link
Collaborator Author

amullen01 commented Jun 13, 2024

This is really interesting: The problem only seems to happen with the RH monthly output. When outputting RH by month and layer and summing over layers, the post-fire behavior seems much more normal.

RH_monthly_layer

@hgenet
Copy link
Collaborator

hgenet commented Jun 13, 2024 via email

@rarutter
Copy link
Collaborator

Oh dear, that's a problem. Yeah, I'll look at it.

@amullen01
Copy link
Collaborator Author

Thanks Ruth. Happy to help debug during our meeting tomorrow as well.

@rarutter
Copy link
Collaborator

The difference is because the total output includes respiration from dead woody debris, while the by-layer output does not. Woody debris respiration is available as a separate output DWDRH, and I'll need to look a bit further and perhaps discuss with you guys how to resolve this.

@hgenet
Copy link
Collaborator

hgenet commented Jun 14, 2024 via email

@amullen01
Copy link
Collaborator Author

deadc_dwdc

@hgenet
Copy link
Collaborator

hgenet commented Jun 15, 2024 via email

@amullen01
Copy link
Collaborator Author

amullen01 commented Jun 17, 2024

The problem appears to be in Vegetation_Bgc.cpp, lines 287 - 318. In this block of code, d2wdebrisc is given a value > 0, dependent on deadc0. deadc is reduced by d2wdebrisc until deadc is depleted, or months post-fire >= 108. This is all fine, however, there is no mechanism to set d2wdebrisc to zero when deadc is zero post-fire so dead woody debris gets added every time step for the rest of the run. At least I think this is what is happening.

When I add the two lines

bd->m_v2soi.d2wdebrisc = 0.0;
bd->m_v2soi.d2wdebrisn = 0.0;

Before lines 287 - 318 in Vegetation_Bgc.cpp, the issue seems to be fixed.

deadc_dwdc_fix Fluxes_fire_exps_DWDC_fix

@rarutter
Copy link
Collaborator

I've been working through this trying to get a handle on what's going on. I ran at Toolik with a single fire, and while I didn't quite get the same dynamics you did, most of them are similar (although DWDC doesn't drop as abruptly, which I think is a good thing). I'll be working on it again later today and will try to more closely match what you've done.

@amullen01 amullen01 added bug science Issues affecting scientific interpretation of modeling results labels Jul 17, 2024
@amullen01
Copy link
Collaborator Author

DWDC currently decays at the rate of rawc. Helene suggests that this rate is too fast. I changed the decay rate for DWDC to that of sompr and it looks a bit better. This will work temporarily but ideally there will eventually be a DWDC decay rate.

dwdc_sompr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug science Issues affecting scientific interpretation of modeling results
Projects
None yet
Development

No branches or pull requests

3 participants