PR-6180 Loosen dependency restrictions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into some version conflicts when trying to install this into our lambda dependency layer. Together with asfadmin/mandible#26 I was able to get it to install with these changes.
Here's the reasoning for these changes:
aiobotocoreLooks like this is only used to import theAioSessionfor typing purposes. This object has existed in the same module since the very firstaiobotocorerelease so I just unpinned the version completely.zarrI didn't look into the API of this, just changed the version constraint to allow semver backwards compatible versions from what was pinned.kerchunkdittos3fsLooks like s3fs only has one very simple API that has never really changed. Since they're using calver I also unpinned this completely.ujsonsame as zarr and kerchunkh5pysame, but this was pinned to 3.6 just because that's what mandible pinning. Haven't checked the API compatibility with this code though. In practice 3.12 is getting installed so it doesn't matter if we pin to 3.6 or 3.12.