Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix image handling #9

Closed
wants to merge 2 commits into from

Conversation

bwl21
Copy link

@bwl21 bwl21 commented Nov 27, 2015

Image handling did not work properly. I tried to fix this (see also #8)

  1. need to use absolute urls, otherwise mosaico's resize approach does not work.
  2. need to fix some of the regular expressions

There are still some leftovers to make things stable:

  • create the upload folders if they don't exist
  • refresh thumbnails
  • refresh static - no clue how to do this, maybe it is even impossible since it depends on the emails produced with the system

* absolute paths
* cleanup computation of urls and server internal paths
@bwl21 bwl21 mentioned this pull request Nov 27, 2015
@bwl21
Copy link
Author

bwl21 commented Dec 9, 2015

I close this pr. it was not considered by ainterpreting and is now out of date

@bwl21 bwl21 closed this Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant