-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Java 10 Support #1007
[WIP] Java 10 Support #1007
Changes from 4 commits
2b7c956
3692260
373e673
7b8604e
2590ba1
19aa8e8
1ce0494
70dbee1
619afd1
7594d05
aa75e06
5917af7
eed5eec
009e950
04c63b0
e6ccb11
f71230c
2f947f8
b581402
b33ea4c
4fa4ad3
c21db96
9d53959
4868f54
29d56c5
cbac644
4dc2635
f7ce203
588d571
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ | |
|
||
# TODO: Change to org.apereo.portal | ||
group=org.jasig.portal | ||
version=5.0.1 | ||
version=5.0.1-SNAPSHOT | ||
|
||
# Project Metadata (NB: copied from CAS; may or may not be used by us; review later) | ||
projectUrl=https://www.apereo.org/projects/uPortal | ||
|
@@ -38,6 +38,7 @@ servletApiDependency=javax.servlet:javax.servlet-api:3.0.1 | |
portletApiDependency=org.apache.portals:portlet-api_2.1.0_spec:1.0 | ||
|
||
# Dependency Versions | ||
activationVersion:1.0.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, that was a mistake sorry. |
||
antVersion=1.8.4 | ||
awsVersion=1.10.65 | ||
apereoPortletUtilsVersion=1.1.0 | ||
|
@@ -75,8 +76,9 @@ httpcomponentsVersion=4.4.4 | |
jacksonVersion=2.5.3 | ||
jansiVersion=1.11 | ||
javaxMailVersion=1.4.5 | ||
javaxmlVersion=1.3.1 | ||
jasyptVersion=1.9.2 | ||
jaxb2basicsVersion=0.6.5.1 | ||
jaxb2basicsVersion=1.11.1 | ||
jgroupsVersion=3.6.13.Final | ||
jjwtVersion=0.6.0 | ||
jlineVersion=2.11 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,8 @@ ext { | |
dependencies { | ||
compile project(':uPortal-concurrency') | ||
|
||
compile "javax.xml.bind:jaxb-api:2.3.0" | ||
compile "javax.annotation:javax.annotation-api:${javaxmlVersion}" | ||
compile "com.fasterxml.jackson.core:jackson-annotations:${jacksonVersion}" | ||
compile "com.fasterxml.jackson.core:jackson-core:${jacksonVersion}" | ||
compile "com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}" | ||
|
@@ -78,6 +80,9 @@ dependencies { | |
compileOnly "${servletApiDependency}" | ||
} | ||
|
||
sourceCompatibility = '9' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤔 its interesting that this needed to be set here. |
||
targetCompatibility = '9' | ||
|
||
/* | ||
* This section is the key to IDE integration. IDE will look for source files in both... | ||
* | ||
|
@@ -96,6 +101,13 @@ sourceSets { | |
// These are the only modifications to build process that are required. | ||
compileJava { | ||
doFirst { | ||
options.compilerArgs += [ | ||
'--class-path', classpath.asPath, | ||
'--module-path', classpath.asPath, | ||
'--add-modules', 'java.sql', | ||
] | ||
classpath = files() | ||
|
||
// Generated sources directory should be present & empty before compilation | ||
generatedSourcesDir.deleteDir() | ||
generatedSourcesDir.mkdirs() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Open Question ❓
How do we want to handle Java versions with Semantic Versioning?
Upgrading from Java 8 to Java 9 could be considered breaking change (major), however Java 9 is something that would be valuable to get into the 5.x release line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought is would be to set a lower target compatibility allowing this to be added in a feature (minor) release.
Then removing the backwards target in uPortal 6.