This repository has been archived by the owner on May 4, 2022. It is now read-only.
fix: Separate remove button into own controller #718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a conflict-free version of #699
In this PR:
Why?
The functionality used to live in
LayoutController
, and every instance of a<remove-button>
in a user's layout was causingLayoutController
to initialize (including thegetLayout()
service call. It's probably better if each instance of the remove button only initializes what it needs to function.Proof that it still works
Contributor License Agreement adherence: