Update configuration to use new messages model #674
Conversation
| 'groupURL': '/portal/api/groups', | ||
| 'kvURL': '/storage', | ||
| 'loginSilentURL': '/portal/Login?silent=true&profile=bucky', | ||
| }, | ||
| 'MESSAGES': { | ||
| 'announcementsEnabled': true, | ||
| 'notificationsEnabled': true, |
There was a problem hiding this comment.
Do we need these flags, or could the enablement of announcements and notifications be implied by whether there are announcement-flavored and notification-flavored items in the messages feed? If there's no announcements in the feed, then they're not enabled. If there's no notifications in the feed, then they're not enabled.
| 'MESSAGES': { | ||
| 'announcementsEnabled': true, | ||
| 'notificationsEnabled': true, | ||
| 'groupFiltering': true, |
There was a problem hiding this comment.
Do we need this flag, or could group filtering be implied by whether there are groups in the items in the messages feed? If groups are specified, filter to them. If they're not, don't worry about it.
There was a problem hiding this comment.
¯\_(ツ)_/¯
Valid questions, but I don't feel confident that the decision to remove the flags should be up to me. As it is, I've just repurposed what was already there.
|
@thevoiceofzeke CI failure is coming for RemarkLint. edit: opened #675 to resolve issue. |
Related to: uw-frame#484
Related to: angularjs-portal overlay updates
In this PR:
Contributor License Agreement adherence: