Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

refactor(npm): Restructure remarklint setup #672

Merged
merged 2 commits into from
Aug 8, 2017
Merged

refactor(npm): Restructure remarklint setup #672

merged 2 commits into from
Aug 8, 2017

Conversation

ChristianMurphy
Copy link
Contributor

Allow remarklint preset rulesets to import the version of remarklint they depend on.
Allow remarklint to fail the build if a warning occurs.
Style shortcut links to include trailing [].


Contributor License Agreement adherence:

remove direct dependency on remark-lint, the preset rulesets import the
correct version by default.
add the frail option to remarklint so style exceptions can fail a build.
ensure that shortcut links have the trailing square brackets.
Copy link
Contributor

@davidmsibley davidmsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristianMurphy
Copy link
Contributor Author

ChristianMurphy commented Aug 8, 2017

@davidmsibley my understanding is [reference] and \[not a reference] are considered too similar, so it further differentiates references with a trailing brackets [reference][]. 🤷‍♂️

@ChristianMurphy ChristianMurphy merged commit cb8fef6 into uPortal-Attic:master Aug 8, 2017
@ChristianMurphy ChristianMurphy deleted the remarklint-update branch August 8, 2017 22:21
@wooorm
Copy link

wooorm commented Aug 9, 2017

[reference] could end up being a link if there’s a definition somewhere later ([reference]: http://example.com), but you probably didn’t intend that, so the thinking goes that it’s better to be explicit ([reference][]) if you meant it, or escape otherwise!

@ChristianMurphy
Copy link
Contributor Author

Thanks @wooorm!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants