This repository has been archived by the owner on May 4, 2022. It is now read-only.
WIP adding basic layout service test #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertein
approved these changes
May 26, 2017
apetro
approved these changes
May 26, 2017
There was a problem hiding this comment.
I don't think it's using those json example files yet. Still maybe good to capture them to repo, but I'd prefer a README.md or other comment more explicitly communicating that they're not yet used. Even TODO in the test expressing hope to use them in the future.
That said, even this small step forward is a step forward. 👍
|
Yup it's not using them. I'll make that explicit, but keep them in the repo. |
ChristianMurphy
approved these changes
May 26, 2017
davidmsibley
force-pushed
the
add-layout-service-tests
branch
from
f1faf8e to
ec27ea9
Compare
|
I completely forgot about this PR. I'll merge after the conflict resolution build runs. |
|
uPortal-Attic/uportal-app-framework#462 seems to have broken these tests. I'll investigate this afternoon. |
1 task
…into add-layout-service-tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting to add tests for the layout service. More useful tests to come, maybe?
Contributor License Agreement adherence: