This repository has been archived by the owner on May 4, 2022. It is now read-only.
MUMUP-2766 Allows MyUW search results if no extra search specified #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug - without web search or directory search enabled, the whole md-tabs would be hidden.
Cosmetic fix - no search results section was not consistent with other search result padding
Shows the MyUW only tab when there is another tab to show (web or directory).
Needs ng-if vs ng-show, because the tab markup still exists with ng-show resulting basically empty tabs.
Before without a web search or directory search enabled:
Before with the no-results styling and results enabled:
After without a web search or directory search enabled:
After with only 1 enabled: