This repository has been archived by the owner on May 4, 2022. It is now read-only.
Fix display of compact widgets #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertein
approved these changes
Oct 10, 2016
timlevett
approved these changes
Oct 10, 2016
apetro
approved these changes
Oct 10, 2016
| <div class='widget-remove' ng-hide='GuestMode'> | ||
| <i title="Remove" class="fa fa-times portlet-options" ng-click="layoutCtrl.removePortlet(portlet.nodeId, portlet.title)"><a aria-label="Remove this app symbol" href="#"></a></i> | ||
| </div> | ||
| <md-button class="widget-action widget-info md-icon-button" aria-label="see a brief description of this app"> |
There was a problem hiding this comment.
Better aria-label if it was clearer about what app would be described?
Alternatively, maybe the widget <a should be aria-describedby this tooltip?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the "widget info" tooltip didn't include compact widgets, and they broke. This PR fixes them.
Before
After