This repository has been archived by the owner on May 4, 2022. It is now read-only.
Patch always logging in issue #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2016 13:35
vertein
approved these changes
Oct 7, 2016
apetro
approved these changes
Oct 7, 2016
timlevett
commented
Oct 7, 2016
| //for some really weird reason the $sessionStorage here isn't being | ||
| //persisted to real session storage, so we have to do it manually. | ||
| $sessionStorage.$apply(); | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So there is a bug where
$sessionStoragein/main.jsdoesn't persist to the actual session storage, super weird. This patch fixes that by doing what the underlying library does.This fixes 2 things:
/portal/Login?silent=true