Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Create directives for types of search results #534

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Create directives for types of search results #534

merged 1 commit into from
Sep 27, 2016

Conversation

thevoiceofzeke
Copy link
Contributor

In this PR:

  • New directive for each type of search results (only serves to reduce copy+pasted code)
  • Fixed a bug that made the "load more" button for MyUW results never appear
    • Currently in prod, if you search a term that would return more than 20 results (like the letter "r"), you will only get 20 results and the "load more" button will not appear
  • Made the marketplace "load more" button sentence case
  • Minor style tweaks
  • Got rid of some unused jQuery in the search controller

screen shot 2016-09-27 at 11 30 05 am

timlevett
timlevett approved these changes Sep 27, 2016
View reviewed changes
angularjs-portal-home/src/main/webapp/my-app/search/controllers.js
$('#wiscDirectorySeeMoreResults').hide();
}
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay for removing this.

@thevoiceofzeke thevoiceofzeke merged commit 13f89e0 into uPortal-Attic:master Sep 27, 2016
@apetro apetro added this to the 5.4.0 milestone Oct 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timlevett timlevett timlevett approved these changes

@apetro apetro apetro approved these changes

Assignees
No one assigned
Labels
minor-suitable-compatible-change
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thevoiceofzeke @apetro @timlevett