Materialize search results page #533
Conversation
| <div ng-show="wiscDirectoryResultsEmpty && !wiscDirectoryTooManyResults" class='no-result'> | ||
| No directory results. | ||
| </div> | ||
| <div ng-repeat="item in wiscDirectoryResults | limitTo:wiscDirectoryResultLimit" class="result"> |
There was a problem hiding this comment.
I may be wrong on this, but this seems like a copy/paste from the "all". Is there a way to only have this code once? Maybe a directive/component? One for a Google Result, one for a directory result, and another for a MyUW result.
There was a problem hiding this comment.
I made a note about that in the PR. I was thinking maybe that works deserves its own story. I don't mind doing it, since I have plenty of time left in this sprint, but I made the PR in its current state because it's the minimum amount of work that still meets the requirements.
There was a problem hiding this comment.
Ah, yes. I see that now. Sounds like a solid plan.
There was a problem hiding this comment.
Backlogged MUMMNG-2833 to capture this idea.
| <md-button ng-click="addToHome(portlet)" | ||
| ng-if="portlet.canAdd && !portlet.hasInLayout && !GuestMode" | ||
| class="md-primary add"> | ||
| <i class="fa fa-plus"></i> Add to home |
There was a problem hiding this comment.
Consider an aria tag to help users who don't visually connect the "Add to home" to the context of which portlet will be added. (As in, "Add {{ portlet.title }} to home").
| Get help from the <a ng-href="{{helpdeskUrl}}" target="_blank">Help Desk</a> | ||
| </p> | ||
| <p ng-if="feedbackUrl"> | ||
| <a ng-href="{{feedbackUrl}}" target="_blank">Give feedback </a>on MyUW search |
There was a problem hiding this comment.
Nitpick: trapping the trailing " " in the hyperlink seems weird.
This PR satisfies the requirements of MUMMNG-2694
In this PR:
Screenshots
### Animations demoNotes:
search-resultsdirective that we can reuse for each category of results. The current version functions fine as is, but a directive would help cut down on copy+pasted code.