Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Adjust marketplace to better utilize theme colors, fix widget title spacing #514

Merged
merged 8 commits into from
Aug 23, 2016
Merged

Adjust marketplace to better utilize theme colors, fix widget title spacing #514

merged 8 commits into from
Aug 23, 2016

Conversation

thevoiceofzeke
Copy link
Contributor

@thevoiceofzeke thevoiceofzeke commented Aug 23, 2016

In this PR:

  • Removed hard-coded colors from marketplace tabs (so other themes don't get red tabs)
  • Added ng-styles to non-material DOM elements that leverage the current material theme
    • Note: These are inline styles, so I'm viewing it as a short-term fix :/
  • Adjusted button appearance/layout in marketplace
    • We get to /apps by clicking "add more to home," so it makes sense that "add to home" should be the primary call to action for each marketplace entry
    • Accent color is only used in raised buttons (so it is a background color instead of text color) -- this will ensure better color contrast for some themes)
  • Adjusted text of the expand widgets toggle to say what it actually does as simply as possible ("expand widgets")
  • Adjusted spacing of widget titles to avoid clipping when text wraps
  • Formatted marketplace controllers so indentation is less maniacal

Screenshots

screen shot 2016-08-23 at 9 55 13 am
screen shot 2016-08-23 at 10 11 12 am
screen shot 2016-08-23 at 11 01 09 am

@thevoiceofzeke thevoiceofzeke changed the title Adjust marketplace to better utilize theme colors Adjust marketplace to better utilize theme colors, fix widget title spacing Aug 23, 2016
@apetro
Copy link
Contributor

apetro commented Aug 23, 2016

"Research Project Resource Guide" is technically one character over our documented maximum title length -- but I'm not sure what one would do about that to comply with the limit? "Research Project Resources"? "Research Project Guide"? Maybe the title limit needs to be a little longer to embrace the reality of the long names of some things in our university world?

So I agree with the style tweak to avoid clipping, it's a good fix. Long thing titles continue to be a design challenge.

<span hide-sm hide-xs>Show expanded mode</span>
<span hide-gt-sm>Show Expanded</span>
<span hide-sm hide-xs>Expand widgets</span>
<span hide-gt-sm>Expand Widgets</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization? Prefer sentence-case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apetro: It's written both ways at the moment because everything in md-menus is capitalized. I'm going to write a PR for frame that makes items in md-menus sentence-case as well (that would be consistent with google's guidelines).

@thevoiceofzeke thevoiceofzeke merged commit 94520fa into uPortal-Attic:master Aug 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants