This repository has been archived by the owner on May 4, 2022. It is now read-only.
MUMUP-2431 Trap exclusive mode error and display message. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var returnMe=-1; | ||
| var data = attemptExclusiveCall(portlet, returnMe); | ||
| if(returnMe===-1){ | ||
| portlet.exclusiveContent="<font color=\"red\">An error occured retrieving your data. This service is unavailable at this time.</font>"; |
There was a problem hiding this comment.
@keirserrie @jjones770 - wanna take a gander at this?
|
A handy screenshot would help me visualize the error html |
| var getExclusiveMarkup = function(portlet) { | ||
|
|
||
| var returnMe=-1; | ||
| var data = attemptExclusiveCall(portlet, returnMe); |
There was a problem hiding this comment.
So we may have to chat about promises. Hit me up when you have a moment.
|
This is how it looks with the dummy text.
|
|
Refactored the change to put it all back under one function, per @timlevett. |
|
|
|
@keirserrie Jess : Ok? See above. |
|
@timlevett : What do you want to do to the style? |
|
Talked in chat, just reiterating: http://getbootstrap.com/components/#alerts would be preferred for this.
|
|
|
|
👍 |
Doug-Reed
added a commit
that referenced
this pull request
Mar 17, 2016
MUMUP-2431 Trap exclusive mode error and display message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side error was bypassing client-side failure function. Moved the $http.get(...) function to it's own method, and test the results of that.