This repository has been archived by the owner on May 4, 2022. It is now read-only.
MUMUP-2407: Priority Notification #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,5 @@ | |||
| <div class="row portlet-frame"> | |||
| <notification-bell mode="priority" class="visible-xs"></notification-bell> | |||
There was a problem hiding this comment.
Is there any way we can make this not be in the header of every single page? Maybe in the app-header or in the frame page itself? like in the uw-body directive?
|
Observation: seems like |
|
@apetro @timlevett it doesn't look like those partials were even necessary, since priority notifications are already attached to the header. I removed them. Now this changeset is really just supplying a few notifications as priority. |
added 2 commits
March 3, 2016 12:05
|
👍 . Hurray for clean, declarative. |
|
👍 |
jhanstra
added a commit
that referenced
this pull request
Mar 3, 2016
MUMUP-2407: Priority Notification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes along with uPortal-Attic/uportal-app-framework#173