This repository has been archived by the owner on May 4, 2022. It is now read-only.
MUMUP-2345 Show Truncated RSS Feed #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $scope.isEmpty = true; | ||
| $scope.loading = false; | ||
| } else { | ||
| if(!$scope.data.responseData |
There was a problem hiding this comment.
Whitespace: \t is problematic.
There was a problem hiding this comment.
We typically use 2 spaces instead of tabs, you can upload the google styleguide to your eclipse and it will magically do that: https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml
|
|
|
(Potentially bad) idea: incorporate the Showing X of Y indicator into the See all button. |
| @@ -8,7 +8,7 @@ | |||
| </a> | |||
| </li> | |||
| <li ng-if='config.showShowing && config.lim && data.responseData.feed.entries.length > config.lim'> | |||
| <p>Showing {{config.lim}} out of {{data.responseData.feed.entries.length}}</p> | |||
| <span class='center'><p class='bold'>Showing {{config.lim}} of {{data.responseData.feed.entries.length}}</p></span> | |||
There was a problem hiding this comment.
Should this be clickable? Launch to {{portlet.url}}?
There was a problem hiding this comment.
@keirserrie said no click on the "Showing X of Y"
There was a problem hiding this comment.
i believe UX decided no on that.
|
👍 |
2 similar comments
|
👍 |
|
👍 |
Doug-Reed
added a commit
that referenced
this pull request
Feb 18, 2016
MUMUP-2345 Show Truncated RSS Feed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logic to show "Showing X of Y" on rss items.