This repository has been archived by the owner on May 4, 2022. It is now read-only.
Directory enhancements #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Conflicts: angularjs-portal-home/src/main/webapp/my-app/search/partials/search-results.html
|
👍 |
|
Also added two commits from Andrew. Sentence case commit and adding period commits. |
|
👍 nicely done |
| </a> | ||
| </p> | ||
| </div> | ||
| </div> | ||
| <div class="seeMoreResults"> | ||
| <p ng-if="wiscDirectoryResultCount>0"> | ||
| <a ng-href="{{$scope.directorySearchUrl + searchTerm}}">See all {{wiscDirectoryResultCount}} directory results</a> | ||
| <p ng-if="wiscDirectoryResultCount>0" id="wiscDirectorySeeMoreResults"> |
There was a problem hiding this comment.
Should this be ng-if="wiscDirectoryResultCount > wiscDirectoryResultLimit" so that the call to action only displays if the action is meaningful, that is, will show more than is already shown?
There was a problem hiding this comment.
I had this thought too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONE. Takes Andrew's commit of Not showing "No Directory Results" when there are too many.
Before
After
TWO. Removes the see all directory results link when focused on directory tab. Also the see all results directory link works and goes to the tab
Before
After
THREE. We now show all the search results (removes the limit) when focused on tab to align with mockups and link text
Before
After