This repository has been archived by the owner on May 4, 2022. It is now read-only.
MUMMNG-2017: Support Manager time and approval as a list-of-links widget #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhanstra
commented
Nov 11, 2015
jhanstra
commented
|
👍 |
jhanstra
added a commit
that referenced
this pull request
Nov 13, 2015
MUMMNG-2017: Support Manager time and approval as a list-of-links widget
| @@ -8,6 +8,7 @@ | |||
| <div class='col-xs-6 v-center center' ng-repeat='item in config.links'> | |||
| <circle-button data-href='{{item.href}}' data-target='{{item.target}}' data-fa-icon='{{item.icon}}' data-disabled='false' data-title='{{item.title}}'></circle-button> | |||
| </div> | |||
| <p class="bold center additional-text">{{config.additionalText}}</p> | |||
There was a problem hiding this comment.
Would it help for this template to truncate the config.additionalText so that if an instance of this widget type is configured with a too-long additionalText it won't overflow its card?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.