This repository has been archived by the owner on May 4, 2022. It is now read-only.
use ng-switch for widget selection #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do love me some ng-switch. 👍 |
timlevett
pushed a commit
that referenced
this pull request
Nov 6, 2015
use ng-switch for widget selection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read about
ng-switchand thought this would be a good case to use it. Did a little logging, for someone that has a single widget on there page, it reduces the amount of calls towidgetCtrl.portletType(portlet)from 188 to 42. Decent improvement.