This repository has been archived by the owner on May 4, 2022. It is now read-only.
MUMMNG-2017: Make list-of-links widget type, LOL #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,9 @@ define(['angular'], function(angular){ | |||
|
|
|||
| var app = angular.module('my-app.layout.widget.controllers', []); | |||
|
|
|||
| app.controller('ListOfLinksController', ['$scope', 'layoutService', function($scope, layoutService){ | |||
| }]); | |||
There was a problem hiding this comment.
if there is nothing to do in the controller, you don't need one true? (directives don't have to have a controller connected to them)
There was a problem hiding this comment.
Right. Kind of put it in there as a placeholder but we could definitely take it out til it's necessary.
| @@ -80,4 +80,8 @@ weather { | |||
| .scroll-widget { | |||
| max-height: 210px; | |||
| overflow-y: scroll; | |||
| } | |||
| .lol .v-center { | |||
|
Special cases:
|
|
This is huge! 👍 Strong work. |
|
One more special case (more than 4 links): Note: this case limits to 7 links. |
|
👍 Hurray for templates. This is how we will scale and make maintenance affordable. |
|
👍 looks great, plus 7 means no scrolling woo hoo |
jhanstra
added a commit
that referenced
this pull request
Nov 5, 2015
MUMMNG-2017: Make list-of-links widget type, LOL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a list-of-links widget type to /web. This widget just displays a grid of four links using the circle link directive. The information about these links (href, title, target, icon) are provided by the
widgetConfig. Entity file changes for other list-of-link widgets coming soon.