Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Edge fix #331

Merged
merged 1 commit into from
May 22, 2020
Merged

MS Edge fix #331

merged 1 commit into from
May 22, 2020

Conversation

olafur-palsson
Copy link
Contributor

globalThis is undefined in MS Edge, this fixes it

@coveralls
Copy link

coveralls commented Mar 24, 2020

Coverage Status

Coverage increased (+0.02%) to 63.456% when pulling d9384d3 on quajoo-gmbh:master into 624743b on uNmAnNeR:master.

@uNmAnNeR
Copy link
Owner

@olafur-palsson globalThis is used internally by imask, we can't just ignore it

@uNmAnNeR uNmAnNeR reopened this Mar 31, 2020
@uNmAnNeR
Copy link
Owner

@olafur-palsson i've checked it one more time. This seems a good solution but I need to add some warnings as well. So please don't close it, i'll complete it soon. Thanks!

@olafur-palsson
Copy link
Contributor Author

Cheers man, sorry about closing it earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants