Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock does not appear to honor overriding default assets.json via Chrome policy #666

Closed
8 tasks done
mikelagasse opened this issue Jul 11, 2019 · 4 comments
Closed
8 tasks done
Labels
Chromium specific to Chromium/Chrome fixed issue has been addressed

Comments

@mikelagasse
Copy link

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Attempting to designate our own default assets.json via Chrome policy (per https://github.com/gorhill/uBlock/wiki/Deploying-uBlock-Origin#modifying-the-list-of-stock-assets) doesn't seem to function as expected.
In my debugging, I see that the URL we designated for the location of our default assets.json is parsed by storage.js but I don't actually see our assets.json attempt to get pulled from the webserver as I believe it's designed to in assets.js. Instead, it uses the bundled assets.json.

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. Set Chrome extension policy via registry
    Key: HKLM\Software\Policies\Google\Chrome\3rdparty\extensions\cjpalhdlnbpafiamejdnhcphjbkeiagm\policy
    adminSettings with value {"timeStamp":1562713627423,"version":"1.20.0","assetsBootstrapLocation":"https://my-url-here.com/assets.json"}
  2. Install uBlock Origin
  3. View settings and see only default assets.json is loaded

Expected behavior:

We expect the our designated custom assets.json to be loaded from the URL we specify.

Actual behavior:

The extension's bundled assets/assets.json is loaded.

Your environment

  • uBlock Origin version: 1.20.0
  • Browser Name and version: Chrome 75.0.3770.100
  • Operating System and version: Window 10
@uBlock-user uBlock-user added something to address something to address Chromium specific to Chromium/Chrome labels Jul 12, 2019
@gorhill
Copy link
Member

gorhill commented Jul 12, 2019

I never really completed usage of assetsBootstrapLocation through admin settings. I have fixed this locally, but I do not want to hold back the current release candidate -- the change needs to be tested through a beta build, so I will have to publish it once current release candidate reaches stable release.

@mikelagasse
Copy link
Author

Thanks, we'd be very interested in helping test the beta build when it's available!

gorhill added a commit to gorhill/uBlock that referenced this issue Jul 18, 2019
@gorhill
Copy link
Member

gorhill commented Jul 18, 2019

You can try the fix in the latest dev build: https://github.com/gorhill/uBlock/releases

@uBlock-user uBlock-user added fixed issue has been addressed and removed something to address something to address labels Jul 18, 2019
@mikelagasse
Copy link
Author

Can confirm this build works as expected, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium specific to Chromium/Chrome fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants