Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelisting a site on Chromium Edge still blocks resources fetched by service worker #1478

Closed
8 tasks done
Lucent opened this issue Jan 30, 2021 · 1 comment
Closed
8 tasks done
Labels
bug Something isn't working fixed issue has been addressed

Comments

@Lucent
Copy link

Lucent commented Jan 30, 2021

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

When the service worker takes over and attempts to handle the fetch for AdSense after whitelisting, uBlock claims in its logger that the request was whitelisted but the browser console shows the request fails. This does not occur on the initial load, only after the service worker takes over.

A specific URL where the issue occurs

https://ptable.com/

Steps to Reproduce

  1. Visit Ptable after whitelisting and clearing cache. Ads load.
  2. Reload Ptable so requests pass through service worker.
  3. Fetch fails: The FetchEvent for "https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js" resulted in a network error response: an object that was not a Response was passed to respondWith(). extra-59fbde3d.js:10 GET https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js net::ERR_FAILED

Expected behavior:

Ads show up properly.

Actual behavior:

Ads are still blocked.

Your environment

  • uBlock Origin version: 1.32.4
  • Browser Name and version: Edge Version 88.0.705.56 (Official build) (64-bit)
  • Operating System and version: Windows 10 19042.746
gorhill added a commit to gorhill/uBlock that referenced this issue Jan 30, 2021
@gorhill
Copy link
Member

gorhill commented Jan 30, 2021

Fixed in next dev build, I will push an emergency fix for 1.33.0 in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants