Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Malware domains #1116

Closed
8 tasks
nicolaasjan opened this issue Jun 19, 2020 · 20 comments
Closed
8 tasks

Remove Malware domains #1116

nicolaasjan opened this issue Jun 19, 2020 · 20 comments
Labels
fixed issue has been addressed wiki related to wiki

Comments

@nicolaasjan
Copy link

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Similar to #984.

I've been watching this list for quite some time now and virtually nothing changes...

The last entry is:
usibw.top phishing private 20200518

usibw.top is a dead domain by now...

I really think it's worth considering the removal of this once great list.

Example of a better alternative at this point would be:
https://gitlab.com/curben/urlhaus-filter (?)

A specific URL where the issue occurs

n/a

Steps to Reproduce:

n/a

Expected behavior:

n/a

Actual behavior:

n/a

Your environment

  • uBlock Origin version: v1.27.11rc2
  • Browser Name and version: Firefox 77.0.1
  • Operating System and version: Linux Mint 19.3
@uBlock-user uBlock-user added the something to address something to address label Jun 19, 2020
@gorhill
Copy link
Member

gorhill commented Jun 19, 2020

Replacing both malware list with Online Malicious URL Blocklist?

The other list, Malicious URL Blocklist, is too large to have it enabled by default, and though uBO can efficiently store it in memory, the large size is an issue because:

  • Default lists have to be part of the package, so this has a negative impact on the size of the package
  • In Chromium, the storage used figure climbs to 37 MB (from ~20 MB)

@nicolaasjan
Copy link
Author

Replacing both malware list with Online Malicious URL Blocklist?

The other list, Malicious URL Blocklist, is too large to have it enabled by default, and though uBO can efficiently store it in memory, the large size is an issue because:

* Default lists have to be part of the package, so this has a negative impact on the size of the package

* In Chromium, the storage used figure climbs to 37 MB (from ~20 MB)

https://gitlab.com/curben/urlhaus-filter/raw/master/urlhaus-filter-online.txt
would be fine , I guess.

I have it in my Custom Filters and it is updated very frequently.

However, I read somewhere that the format is not entirely UBO compatible.
Is that true and if so, is it up to Urlhaus to address that?

@gorhill
Copy link
Member

gorhill commented Jun 19, 2020

I looked at the list and it's fine. Ideally, entries for which there is a path should be prefixed with ||, but given how unique those paths are, it's highly unlikely to lead to false positive. For example:

ak.imgfarm.com/images/nocache/vicinio/100000417/19562-111117113753/[email protected]

Would normally be written as:

||ak.imgfarm.com/images/nocache/vicinio/100000417/19562-111117113753/[email protected]

But the filter is so unique that I really don't see the need for the ||, and actually it's being stored slightly more efficiently without the || (because one less condition to evaluate). So I am fine to have the list as is.

@Yuki2718
Copy link

However, I read somewhere that the format is not entirely UBO compatible.
Is that true and if so, is it up to Urlhaus to address that?

Add the list and pick a URL from it for downloading .exe, and then access the site and it will be downloaded without an issue. $document or $all modifier is needed to prevent it.

@gorhill
Copy link
Member

gorhill commented Jun 19, 2020

Yes, I overlooked this. Maybe the best way to approach this is for a list to be able to hint at its primary purpose so that uBO parses the filters to ensure they apply to requests for the main document as well.

@Yuki2718
Copy link

Yes, I overlooked this. Maybe the best way to approach this is for a list to be able to hint at its primary purpose so that uBO parses the filters to ensure they apply to requests for the main document as well.

Is that worth troubling? I wonder whether @MDLeom can simply add $all, even for all the rules if choosing specific rules is trouble for him.

@nicolaasjan
Copy link
Author

However, I read somewhere that the format is not entirely UBO compatible.
Is that true and if so, is it up to Urlhaus to address that?

Add the list and pick a URL from it for downloading .exe, and then access the site and it will be downloaded without an issue. $document or $all modifier is needed to prevent it.

Yes, when I enter the URL (.xpi file) Gorhill mentioned above I get this:
screenshot_error

@VernonStow
Copy link

VernonStow commented Jul 6, 2020

I noticed today that the Urlhaus author has added $all to the entries targeting specific bad file downloads for the filterlists recommended for uBO. Much appreciated!

https://gitlab.com/curben/urlhaus-filter/raw/master/urlhaus-filter-online.txt

@gwarser
Copy link

gwarser commented Jul 6, 2020

...ajax-made/1^$all

Hmmm, ^ should be removed or replaced by *.

https://gitlab.com/curben/urlhaus-filter/-/commit/859dfd03c6e9e5af6f1fac29bc9b22d1e0046111

@gorhill
Copy link
Member

gorhill commented Jul 6, 2020

Great, this means I can go ahead with this. So both current malware domain lists will be removed from stock lists and replaced with Online Malicious URL Blocklist.

gorhill added a commit to uBlockOrigin/uAssets that referenced this issue Jul 6, 2020
gorhill added a commit to gorhill/uBlock that referenced this issue Jul 6, 2020
Related issues:
- uBlockOrigin/uBlock-issues#1116
- uBlockOrigin/uBlock-issues#984

It has been found that the two malware lists uBO uses by
default appear to be essentially no longer maintained.

urlhaus list[1] has been identified by the community as
being well maintained and as being actually useful as a
default malware-related list in uBO, since it's being updated
every day from a database of top domains and specific URLs
identified as serving malicious content. Additionally, the
maintainer of urlhaus list has taken steps to increase
compatibility with uBO[2].

The decision has been to replace the current two malware-
related lists with urlhaus list, which will be enabled by
default in uBO -- and this means that list will be part of
uBO's package from now on.

For those who have the two removed malware lists enabled,
these will be moved to the custom lists section -- they
will still be enabled. It is suggested users remove them from
their selection of lists as their usefulness at this point
is questionable.

[1] https://gitlab.com/curben/urlhaus-filter
[2] https://gitlab.com/curben/urlhaus-filter/-/commit/859dfd03c6e9e5af6f1fac29bc9b22d1e0046111
@Yuki2718
Copy link

Yuki2718 commented Jul 6, 2020

Hmmm, ^ should be removed or replaced by *.

Can I ask about what is the exact problem? I mean if ajax-made/1_ or such doesn't proceed.

@gwarser
Copy link

gwarser commented Jul 6, 2020

Can I ask about what is the exact problem?

?

https://gitlab.com/curben/urlhaus-filter/-/commit/859dfd03c6e9e5af6f1fac29bc9b22d1e0046111#0329d79171f0f92caecdb36bd26a669696d1042b_103_106

@gorhill
Copy link
Member

gorhill commented Jul 6, 2020

The ^ is not really a big issue, it's just that it's not really needed. The filters will be dealt with properly by uBO with the ^, but semantically the filters are better without it. I also consider that semantically the * is also not needed, it appears all those URL-based filters are complete, I don't think any of them is truncated mid-token.

@Yuki2718
Copy link

Yuki2718 commented Jul 6, 2020

@gwarser @gorhill Thanks!

JustOff pushed a commit to gorhill/uBlock-for-firefox-legacy that referenced this issue Jul 6, 2020
Related issues:
- uBlockOrigin/uBlock-issues#1116
- uBlockOrigin/uBlock-issues#984

It has been found that the two malware lists uBO uses by
default appear to be essentially no longer maintained.

urlhaus list[1] has been identified by the community as
being well maintained and as being actually useful as a
default malware-related list in uBO, since it's being updated
every day from a database of top domains and specific URLs
identified as serving malicious content. Additionally, the
maintainer of urlhaus list has taken steps to increase
compatibility with uBO[2].

The decision has been to replace the current two malware-
related lists with urlhaus list, which will be enabled by
default in uBO -- and this means that list will be part of
uBO's package from now on.

For those who have the two removed malware lists enabled,
these will be moved to the custom lists section -- they
will still be enabled. It is suggested users remove them from
their selection of lists as their usefulness at this point
is questionable.

[1] https://gitlab.com/curben/urlhaus-filter
[2] https://gitlab.com/curben/urlhaus-filter/-/commit/859dfd03c6e9e5af6f1fac29bc9b22d1e0046111
@curbengh
Copy link

curbengh commented Jul 7, 2020

Maintainer of urlhaus-filter here. Currently urlhaus-filter-online.txt uses:

||example-bad.com/bad-page.html^$all

Should I use the following syntax instead (i.e. remove the ^)?

||example-bad.com/bad-page.html$all

@gorhill
Copy link
Member

gorhill commented Jul 7, 2020

Yes, second form is better, it's semantically correct -- the ^ is equivalent to regex /[^%.0-9a-z_-]|$/ -- I don't think it's something we expect after the pattern in your case.

Thanks for maintaining that list, I consider this helps make uBO better.

curbengh pushed a commit to curbengh/urlhaus-filter that referenced this issue Jul 7, 2020
@curbengh
Copy link

curbengh commented Jul 7, 2020

Updated the script. The filter will be updated in ~10 hours.

Thanks for maintaining that list, I consider this helps make uBO better.

No problem. I'm a longtime uBO user, always wanted to contribute.

@lipici
Copy link

lipici commented Jul 7, 2020

i updated to uBlock Origin development build v1.28.1b5 but Malware Domain List 1,104 used out of 1,104 and Malware domains 26,838 used out of 26,853 didnt moved to custom list and https://gitlab.com/curben/urlhaus-filter hasnt be added

L.E: appears only after you purge cache and update filters

curbengh pushed a commit to curbengh/phishing-filter that referenced this issue Jul 7, 2020
@gwarser gwarser added the fixed issue has been addressed label Jul 8, 2020
@gwarser gwarser closed this as completed Jul 8, 2020
@sith-on-mars
Copy link

Does that mean now the new Online Malicious URL Blocklist can completely replace both Malware Domain List and Malware Domain?

If yes, could you please update the recommended lists in different blocking modes, like this page?

@gwarser gwarser added the wiki related to wiki label Jul 11, 2020
@gwarser
Copy link

gwarser commented Jul 11, 2020

https://github.com/uBlockOrigin/uBlock-issues/wiki/_compare/c65978da28d98a402840957bbb11c25b36ad699c...f68f791486395a7b15860ccd4ce5a12fbd51061d

@uBlock-user uBlock-user removed the something to address something to address label Jul 13, 2020
cqx931 pushed a commit to cqx931/AdNauseam that referenced this issue Jul 28, 2020
Related issues:
- uBlockOrigin/uBlock-issues#1116
- uBlockOrigin/uBlock-issues#984

It has been found that the two malware lists uBO uses by
default appear to be essentially no longer maintained.

urlhaus list[1] has been identified by the community as
being well maintained and as being actually useful as a
default malware-related list in uBO, since it's being updated
every day from a database of top domains and specific URLs
identified as serving malicious content. Additionally, the
maintainer of urlhaus list has taken steps to increase
compatibility with uBO[2].

The decision has been to replace the current two malware-
related lists with urlhaus list, which will be enabled by
default in uBO -- and this means that list will be part of
uBO's package from now on.

For those who have the two removed malware lists enabled,
these will be moved to the custom lists section -- they
will still be enabled. It is suggested users remove them from
their selection of lists as their usefulness at this point
is questionable.

[1] https://gitlab.com/curben/urlhaus-filter
[2] https://gitlab.com/curben/urlhaus-filter/-/commit/859dfd03c6e9e5af6f1fac29bc9b22d1e0046111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issue has been addressed wiki related to wiki
Projects
None yet
Development

No branches or pull requests

9 participants