Requests in iframe count as first-party

[MasterKia]

First add this to avoid EasyList false positive:

.com/ads/$subdocument,domain=~developers.google.com|~sabotage-films.com,badfilter

Then add this and go to ejiga.com/w/SQxMqtz:

||tamasha.com^$3p,~frame

Notice that only a handful of requests except the iframe are blocked:

Change the last filter to:

||tamasha.com^$1p,~frame

Notice that all requests except the iframe are blocked (as intended):

But now, tamasha.com/v/j5B3k is broken.

The goal is to block tamasha.com on all third-party sites but only allowing its video player assets (using exception filters), but it seems to be impossible without breaking the site itself.

This is impossible to do using uBO because:

Any request from an iframe to the iframe URL is 100% 1p.

What can be done about this?

[Yuki2718]

The goal is to block tamasha.com on all third-party sites but only allowing its video player assets

is already 100% achieved by ||tamasha.com^$3p,~frame, it's not uBO specifically counts these requests as 1p, but they are in all senses 1p because they come from tamasha.com and go to tamasha.com.

Simple question: why you wanna block these requests except when user visited the site, in other words, what specific problem does that solve? I don't understant why

||tamasha.com/dist/*/contrib/player/js/videojs.ima.min.js
||tamasha.com/dist/*/contrib/player/js/videojs-contrib.min.js
||tamasha.com/dist/*/contrib/player/js/ima

is not desirable.

[Yuki2718]

This is becoming a loop, you somehow think 1p requests should be treated as 3p.

[MasterKia]

it's not that uBO specifically counts these requests as 1p, but they are in all senses 1p.

In this context I don't think they qualify as 1p requests.

ejiga.com => tamasha.com [iframe] => tamasha.com [scripts]

Why count the [scripts] request as 1p when it's initiated by ejiga.com loading the tamasha.com iframe in the first place?

[Yuki2718]

I give up and let others to explain.

[MasterKia]

If ejiga.com is removed from the equation, then it should be count as 1p request.

[MasterKia]

I don't understant why these filters are not desirable.

Because Ads/tracking scripts change faster than video player scripts.

[gorhill]

What can be done about this?

Nothing, it's the actual semantic of 1p/3p in easylist-compatible filter syntax -- changing the semantic would lead to widespread breakage. That's just the way things work.

[MasterKia]

What about changing the semantics to count requests as 3p only if they're initiated by an iframe?

How would that lead to widespread breakage?
(Sorry I can't come up with any real world example).

[Yuki2718]

ANY 1p exception won't work for frame in that case. E.g. @@||youtube.com/api/analytics/$~third-party won't work for embedded player and if it's still needed all embedded YT will be broken. There are no difference btwn iframe (subdocument) and main document, virtually any websites can be embedded as iframe. IMHO you have to overcome your desire for what you think things should be, and accept and get yourself to be used to what things are and logic behind them (uBlockOrigin/uBlock-issues#2244 and some past comments are in my mind).

[MasterKia]

you have to overcome your desire for what you think things should be
accept and get yourself to be used to what things are

That's not how new features are born, e.g. this would've never been possible if the user forced himself to use cosmetic filters:
gorhill/uBlock@152120b

[Yuki2718]

New feature born by understanding and following current logic of how web and uBO work and still finding something not filled by current implementation.

[Yuki2718]

@gorhill Is it technically possible to take root context into account? A problem is @@||tpc.googlesyndication.com/pagead/js/$domain=googleads.g.doubleclick.net in EL is needed for https://game.goo.ne.jp/goo/game/469 but not for https://anydebrid.com/ or https://skmedix.pl/downloads.

[gorhill]

technically possible to take root context into account?

We discussed a rootDomain option somewhere else a long time ago. Here is not the place for such discussion, as it's unrelated and there is no way I will ever change the semantic of 1p/3p in uBO's static network filtering engine, which is what the discussion was about here.

[uBlock-user]

@gorhill I suggested rootdomain in https://github.com/uBlockOrigin/uBlock-discussions/discussions/354#discussioncomment-5307255. Are you still open to implementing it ?

[gorhill]

That's the one I was thinking about. As usual, it's about the balance of work required/future maintenance of that code vs. number of cases solved.

[uBlock-user]

It will solve mine and this case alongwith all similar cases where iframes is involved.

[stephenhawk8054]

This issue might also need the root solution: #16014 (comment)