Make the migration script more robust #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So wlk.yt migrates correctly.
It would be better if we could use a prepared statement here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB is schema-less, so it can contain arbitrary stuff in theory. After the first few months we've been quite diligent about keeping models compatible, but for WLK, there's some very old data in MongoDB that doesn't quite follow the current schema.
This patches the migration script to support that sort of bad data, including:
createdAtandupdatedAttimestamps (defaulted to the current date)endproperty for playlist item (only one case, defaulting to 0)Migration took about 2 minutes to run on my machine. Not ideal, but fine, I think. If there's even any other servers out there today they won't have nearly as much data as WLK does.