tinygo: enable cmd/core/init #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3062 +/- ##
==========================================
- Coverage 59.88% 59.88% -0.01%
==========================================
Files 580 580
Lines 38186 38186
==========================================
- Hits 22867 22866 -1
- Misses 15319 15320 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rminnich
reviewed
Aug 7, 2024
rminnich
added
the
Awaiting author
|
@rminnich re-running the ci seems to have fixed that. |
binjip978
approved these changes
Aug 8, 2024
Add conditional compilation to exclude any use of network packages for now. Further, `klauspost/zstd` is used, so to build this cmdlet with tinygo requires to set the build tag `noasm` as well: ``` tinygo build -tags noasm . ``` Signed-off-by: leongross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conditional compilation to exclude any use of network packages for now. Further,
klauspost/zstdis used, so to build this cmdlet with tinygo requires to set the build tagnoasmas well. Since this package usesunix.Syncthe latesttinygorelease cannot yet be used but instead, a dev build is required.@rminnich