loadFSPackages: do not ignore errors from addPkg #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rminnich
requested review from
hugelgupf,
10000TB,
andrewsun2898,
ChriMarMe,
jensdrenhaus and
walterchris
loadFSPackages is currently ignoring errors returned by addPkg. This results in a very bad outcome: firmware images that are missing commands. For example, if you corrupt, e.g., date, u-root will still build a firmware image with date missing. This has, in turn, resulted in the creation of broken images (found in the wild for those of us using cpu). There is now a test in u-root specifically for the case that this error is ignored (u-root/u-root#2451) and this fix makes that new test work, where it does not pass currently. Signed-off-by: Ronald G. Minnich <[email protected]>
rminnich
force-pushed
the
donotignoreerrors
branch
from
7021515 to
7d9bcd7
Compare
10000TB
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadFSPackages is currently ignoring errors returned by addPkg.
This results in a very bad outcome: firmware images that are missing commands.
For example, if you corrupt, e.g., date, u-root will still build
a firmware image with date missing.
This has, in turn, resulted in the creation of broken images (found in
the wild for those of us using cpu).
There is now a test in u-root specifically for the case that
this error is ignored (u-root/u-root#2451)
and this fix makes that new test work, where it does not pass
currently.
Signed-off-by: Ronald G. Minnich [email protected]