StreamingEngine Parallel Segment Fetching Support #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrelltle
commented
Nov 24, 2022
| this.stream_, | ||
| ); | ||
| const endTime = startTime + duration; | ||
| for (const reference of this.segmentPrefetchMap_.keys()) { |
tyrelltle
commented
Nov 24, 2022
| this.stream_ = stream; | ||
|
|
||
| /** @private {number} */ | ||
| this.prefetchPosTime_ = 0; |
There was a problem hiding this comment.
TODO: change to clearer name
|
Incremental code coverage: 52.73% |
tyrelltle
force-pushed
the
parallelfetching
branch
from
26c038a to
ca32f5a
Compare
|
Closing in favour of shaka-project#4784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR in in draft and will be reviewed by the shaka community soon.
Currently Shaka fetches the segments sequentially. The segment at future time will not be fetched until the segment at current time position is fetched / appended.
This PR adds the capaiblity of paralllel fetching the next N segments. This will reduce the chance of re-buffering especially when user plays at higher playback speed with limited network bandwidth.