Fix delimiting within <choose> and <layout> for CSL
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes typst#180 A design trade-off: The delimiter stack uses `String` instead of `&str`. Using `&str` could eliminate many cloning, but at the cost of introducing complex lifetimes. Considering that delimiters are typically short, I choose `String`.
Open
YDX-2147483647
added a commit
to YDX-2147483647/citationberg
that referenced
this pull request
Jan 22, 2025
Resolves typst#15 Relates-to: typst/hayagriva#269
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix delimiting within
<choose>and<layout>for CSLFixes The
delimiterattribute of<group>is not applied to items inside<choose>#180Fixes Issue with CSL Rendering (OSCOLA no ibid Style) #109
Frank Mittelbach and others, The Latex Companion (2nd ednAddison-Wesley Professional 2004).Frank Mittelbach and others, The Latex Companion (2nd edn, Addison-Wesley Professional 2004).2nd edn.Add a minimal test case
Title_Edition_PublisherPlace_TitleEditionPublisherPlaceTitle_Edition_Publisher_Place_TitleEditionPublisherPlace_between the first Publisher Place.There is a design trade-off:
The delimiter stack uses
Stringinstead of&str.Using
&strcould eliminate many cloning, but at the cost of introducing complex lifetimes.Considering that delimiters are typically short, I choose
String.Besides, I bump some
*.cborto pass tests. If this is not desired, I can reset the commit.