Fix sorting citation by citation number #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to defer sorting the citations until the citation numbers are assigned. Fixes typst#115
Citation number sorting is coverd in the test suite only by CITATIONS tests which we do not support. This commit adds support for local test cases and adapts one such test to use CITATION-ITEMS.
|
I just wondered why my citations are not sorted properly and I have these weird combinations sometimes. Thanks for your PR, now I know that I should have configured my CSL in the right way. Hope this gets merged soon 👍 |
|
I believe this would close #115 |
|
Thank you! 💙 |
danilasar
pushed a commit
to danilasar/hayagriva
that referenced
this pull request
Dec 31, 2024
* Fix sorting citation by citation number We need to defer sorting the citations until the citation numbers are assigned. * Add local test for sorting by citation number Citation number sorting is coverd in the test suite only by CITATIONS tests which we do not support. This commit adds support for local test cases and adapts one such test to use CITATION-ITEMS. * use generics for citation number * move local tests to tests/local --------- Co-authored-by: PgBiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Citations with citation numbers currently aren't sorted properly, for example output from the test in the second commit:
This PR defers sorting the citations until
finishis called and the citation numbers are determined.Fixes #115