Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor and affiliated doesn't render well with APA. #73

Closed
JuanM04 opened this issue Nov 2, 2023 · 1 comment
Closed

editor and affiliated doesn't render well with APA. #73

JuanM04 opened this issue Nov 2, 2023 · 1 comment

Comments

@JuanM04
Copy link

JuanM04 commented Nov 2, 2023

In my Typst document, using #bibliography("bibliography.yml", style: "apa") and #set text(lang: "es"), and having this bibliography.yml:

stallings:
  type: Book
  title: Sistemas operativos
  author: Stallings, William
  editor: Martín-Romo, Miguel
  affiliated:
    - role: translator
      names:
        - Peña Sánchez, José María
        - Pérez Costoya, Fernando
        - de los Santos Pérez Hernández, María
        - Robles Forcada, Víctor
        - Rosales García, Francisco Javier
  publisher: Pearson Educación
  edition: 5
  date: 2005
  serial-number:
    isbn: 84-205-4462-0
  language: es
  page-total: 872

The reference renders like this:

image

Notice the double ; and the missing ; between the editor and the translators.

@zepinglee
Copy link
Contributor

do_label(NameLabelPosition::BeforeName, ctx);
add_names(self, ctx, persons, &cs_name, forms, variable);
do_label(NameLabelPosition::AfterName, ctx);
if i > 0 {
let delim = self.delimiter(ctx.writing.name_options.last());
if !delim.is_empty() {
let delim = delim.to_string();
ctx.push_str(&delim);
}
}

This bug should be fixed by swapping the names and delimiter.

zepinglee added a commit to zepinglee/hayagriva that referenced this issue Nov 3, 2023
zepinglee added a commit to zepinglee/hayagriva that referenced this issue Nov 3, 2023
@reknih reknih closed this as completed in 12cb55b Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants