Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an options parameter to body-parser with limit #38

Merged
merged 2 commits into from
Jan 7, 2015

Conversation

GSchutz
Copy link
Contributor

@GSchutz GSchutz commented Dec 16, 2014

fix #37

@typicode
Copy link
Owner

Hi Guilherme,

Thanks for the PR didn't even know there was such a limit :)
I'm curious about your use-case, why so much data?

Also, if there's no drawbacks, I think a higher limit can be set directly by default and the CLI option can be removed. Do you prefer me to do it or can you make another PR?

@GSchutz GSchutz force-pushed the master branch 2 times, most recently from 0f86dfb to 363e10e Compare January 5, 2015 15:43
@GSchutz
Copy link
Contributor Author

GSchutz commented Jan 5, 2015

Hi typicode,

I'm building an application using SVG to create maps, and the maps will be very large, I was making a test and reach this limit (150kb) that is the default in the body-parser module.

I made your request, just added the default limit to 10mb and removed the CLI option.

@typicode
Copy link
Owner

typicode commented Jan 7, 2015

Thanks, merging it :)

typicode added a commit that referenced this pull request Jan 7, 2015
Added an options parameter to body-parser with limit
@typicode typicode merged commit 21e90fc into typicode:master Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error HTTP 413 Request entity too large
2 participants