Support cygpath for cygwin-based git executable

[kwonoj]

This PR updates behavior of getting git path for edge-case windows users, like using git executable from msys2 or similar (i.e, cygwin).

Since those git executable returns path as *nix style in windows system, it'll end up husky hook installation fails by

husky
setting up hooks in .git/hooks
fs.js:922
return binding.mkdir(pathModule._makeLong(path),
^

Error: ENOENT: no such file or directory, mkdir 'Z:\z\github\g.git\hooks'
at Error (native)
at Object.fs.mkdirSync (fs.js:922:18)
at Object.module.exports.create (Z:\github\g\node_modules\husky\src\index.js:123:33)
at Z:\github\g\node_modules\husky\bin\install.js:22:13
at Array.forEach (native)
at Z:\github\g\node_modules\husky\bin\install.js:20:11
at Z:\github\g\node_modules\husky\src\index.js:17:9
at ChildProcess.exithandler (child_process.js:193:7)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)

try to create hook under Z:\z\github\g\.git\hooks, instead of correct windows path Z:\github\g\.git\hooks

In changes, it borrows cygpath included in msys2 and cygwin and let it correct path to windows style paths.

[the0neWhoKnocks]

I was literally just working on a fix for this. My fix was

// src/index.js:17

if( stdout.indexOf('cygdrive') > -1 ){
  stdout = stdout.replace(/\/cygdrive\/([a-z])\//, '$1:/')
}

Yours seems more comprehensive. Any idea when this'll make it in? Would be nice to be able to use this with Cygwin.

[kwonoj]

@the0neWhoKnocks suggested regex will work on cygwin, but won't on msys2. I'd thought of direct string match-replace first, but choose to rely on cygpath instead.

[the0neWhoKnocks]

@kwonoj - correct hence my "more comprehensive" statement ;-).

@typicode - There an idea of when this'll get merged in?

[typicode]

Since cygwin doesn't seem to have a great support in Node, I have mixed feelings about adding cygwin specific commands/code in husky.
nodejs/node-v0.x-archive#6459
https://github.com/npm/npm#installing-on-cygwin

That said, I'm considering https://www.npmjs.com/package/find-parent-dir as an alternative way to find .git directory than git rev-parse.

I've not yet tested it on cygwin but maybe it wouldn't have the same issue with Z:\z\github\.git\hooks?

[kwonoj]

I've been previously suggested app-root-path module in other packages having similar purpose (lint-staged/lint-staged#19) which works gracefully on most windows configuration. This PR intended to amend existing behavior only, if you'd update behavior to not to use git it's fine to close PR without check in.

[typicode]

I've just published a beta version that doesn't rely on git command and should work with cygwin. If you want to give it a try:

npm install husky@beta 

Let me know if you still have issues with it.

[the0neWhoKnocks]

@typicode - Gave the beta a whirl and things are working as they used to again. 👍

[typicode]

Awesome thanks @kwonoj, @the0neWhoKnocks for the feedback and help.

[aminya]

Isn't this related to #673 ?