Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for windows gui clients #69

Merged
merged 1 commit into from
Oct 9, 2016
Merged

fix: add support for windows gui clients #69

merged 1 commit into from
Oct 9, 2016

Conversation

cecilia-sanare
Copy link
Contributor

Closes #49

// https://github.com/typicode/husky/issues/49
arr = arr.concat([
'export PATH="$PATH:/c/Program Files/nodejs"'
])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it break unix stuff?

Copy link
Contributor Author

@cecilia-sanare cecilia-sanare Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code should only run on Windows.

The if that this else builds off of:

if (process.platform !== 'win32') {
  // non-windows logic (usage of nvm and what not is up here)
} else {
  // windows logic
}

Source: https://github.com/nick-woodward/husky/blob/bd2996adbab2b02e9dcd047040cb1b094f24bfdb/src/index.js#L59

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with adding a PATH in Windows, but out of curiosity C:\Program... doesn't work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same, but I echoed out the path to a file and they both referenced the C drive in that format.

I ended up testing this with the CLI and GitHub Desktop.

@cecilia-sanare
Copy link
Contributor Author

Hey @typicode can you look at this when you get the chance?

@typicode
Copy link
Owner

typicode commented Oct 7, 2016

Sure, I hope to be able to do it this week-end

@typicode
Copy link
Owner

typicode commented Oct 9, 2016

Thank you 👍

@typicode typicode merged commit 100ad1e into typicode:master Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants