detailed/extended error messages #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be interested to know why this is lingering with no review. It seems to be a big part of what is needed to translate error messages without having to re-implement each validator. If it's a bad approach could you suggest something better and I'll take a shot at a pull request? |
|
Hi! Sorry for the late review. Can you rebase this to the current develop (or create a new PR). You will have to
|
NoNameProvided
added
the
status: awaiting answer
This comment has been minimized.
This comment has been minimized.
|
@HonoluluHenk Will you continue working on this PR? |
|
is this still going to be reviewed? |
|
Unfortunately, I cannot invest anymore time into this PR :( |
NoNameProvided
removed
the
status: awaiting answer
|
Closing this as the author noted he is not interested in pushing this anymore. If someone wants to pick this up, please open a feature idea first on the discussion tab to decide how we want to approach this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return constraint args in ValidationError in a backwards compatible way.
Might help a lot with: