Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for runtime requirements when depending on external stub packages #152

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

hamdanal
Copy link
Contributor

When a typeshed package depends on an external stub-only package, its runtime package must depend on the corresponding runtime package of the stub-only dependency. For example, types-geopandas requiring pandas-stubs means geopandas must require pandas, not pandas-stubs.

Unblocks: python/typeshed#12990

Copy link
Contributor

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit ecec539 into typeshed-internal:main Nov 25, 2024
3 checks passed
@hamdanal hamdanal deleted the runtime-vs-typing-req branch November 25, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants